safe pipe use in hdr long test #13998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements safe execution wrappers for pipeline operations in HDR long tests to enhance test robustness by retrying on failure.
- Introduces two functions, safe_wait_for_frames and safe_start_pipe, with retry logic.
- Replaces direct calls to pipe.wait_for_frames() and pipe.start(cfg) with the new safe functions in various test scenarios.
Nir-Az
reviewed
May 13, 2025
| import time | ||
|
|
||
|
|
||
| def safe_wait_for_frames(pipe, max_retries=10): |
There was a problem hiding this comment.
Lets make sure we need it, not sure we do
Nir-Az
reviewed
May 13, 2025
Nir-Az
reviewed
May 14, 2025
| return func() | ||
| except Exception as e: | ||
| print(f"Attempt {attempt + 1} failed with exception: {e}") | ||
| print("Failed to execute the function after maximum retries.") |
There was a problem hiding this comment.
Why not change the 2 prints to log.w and log.e?
Nir-Az
approved these changes
May 15, 2025
Nir-Az
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: LRS-1257