Fix incorrect IMU data in SDK #13808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Mar 2, 2025
src/ds/d400/d400-motion.cpp
Outdated
|
|
||
| double d400_motion_base::get_gyro_default_scale() const | ||
| { | ||
| // FW scale in the HID feature report was 10 up to 5.16, changed to 1000 to support gyro sensitivity option. |
There was a problem hiding this comment.
Please clarify that 5.16 is a FW version
Nir-Az
reviewed
Mar 2, 2025
Nir-Az
approved these changes
Mar 2, 2025
OhadMeir
approved these changes
Mar 2, 2025
OhadMeir
reviewed
Mar 2, 2025
| return _ds_motion_common->get_motion_intrinsics(stream); | ||
| } | ||
|
|
||
| bool d400_motion_base::is_imu_high_accuracy() const |
There was a problem hiding this comment.
Can we remove overload from d400_motion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by RSDSO-20045