fix-playback-color-stream-format-using-DDS #13679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
approved these changes
Jan 13, 2025
OhadMeir
reviewed
Jan 13, 2025
src/dds/rs-dds-sensor-proxy.h
Outdated
| std::map< std::string, streaming_impl > _streaming_by_name; | ||
|
|
||
| formats_converter _formats_converter; | ||
| stream_profiles _target_profiles; |
There was a problem hiding this comment.
Please rename _active_converted_profiles.
"target profiles" is a term used inside the converted and is not applicable here. Also these are not all the profiles, just those set by open.
OhadMeir
reviewed
Jan 13, 2025
src/dds/rs-dds-sensor-proxy.cpp
Outdated
| { | ||
| _formats_converter.prepare_to_convert( profiles ); | ||
|
|
||
| _target_profiles = profiles; |
There was a problem hiding this comment.
Should implement
void dds_sensor_proxy::close()
{
software_sensor::close();
_target_profiles.clear();
}
noacoohen
force-pushed
the
d555_color_stream_show_wrong_format
branch
from
eefb28e to
a966de6
Compare
OhadMeir
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by RSDEV-3018