Skip to content

Viewer displays options in the order reported by librealsense #13219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2024
Merged

Viewer displays options in the order reported by librealsense #13219

merged 3 commits into from
Aug 1, 2024
+64 −26

Conversation

@maloel
Copy link
Contributor

@maloel maloel commented Jul 31, 2024

SW devices now give options in the same order they were registered.
I.e., DDS devices will follow the order provided by the camera.

@maloel maloel requested a review from Nir-Az July 31, 2024 07:58
Nir-Az
Nir-Az reviewed Jul 31, 2024
View reviewed changes
Nir-Az
Nir-Az reviewed Jul 31, 2024
View reviewed changes
@Nir-Az
Copy link
Collaborator

Nir-Az commented Jul 31, 2024

SW devices now give options in the same order they were registered. I.e., DDS devices will follow the order provided by the camera.

How do you distinguish SW device and DDS device?

@maloel
Copy link
Contributor Author

maloel commented Jul 31, 2024

How do you distinguish SW device and DDS device?

SW devices in general.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jul 31, 2024

Any idea about Linux LibCI?

@maloel
Copy link
Contributor Author

maloel commented Jul 31, 2024 •
edited
Loading

Any idea about Linux LibCI?

I think the machine needs a restart or something:

19:53:21  -I- Discovering devices ...
19:53:21  -D- <module 'pyrealsense2' from '/home/jenkins/workspace/LRS_linux_compile_lib_ci/x86_64/static/Release/pyrealsense2.cpython-310-x86_64-linux-gnu.so'>
19:53:21  -D- discovering Acroname modules ...

No devices are seen

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jul 31, 2024

Member

Any idea about Linux LibCI?

I think the machine needs a restart or something:

19:53:21  -I- Discovering devices ...
19:53:21  -D- <module 'pyrealsense2' from '/home/jenkins/workspace/LRS_linux_compile_lib_ci/x86_64/static/Release/pyrealsense2.cpython-310-x86_64-linux-gnu.so'>
19:53:21  -D- discovering Acroname modules ...

No devices are seen

Rebooted and retriggered, I'll approve and you can monitor the build

@maloel maloel merged commit b7ba086 into IntelRealSense:development Aug 1, 2024
@maloel maloel deleted the dds-option-order branch August 1, 2024 04:46
@maloel maloel added the tools label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees

No one assigned

Labels

dds enhancement tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maloel @Nir-Az