set_calibration_table removed from engine #13189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Jul 28, 2024
| void d500_auto_calibrated::set_calibration_table(const std::vector<uint8_t>& calibration) | ||
| { | ||
| _calib_engine->set_calibration_table(calibration, _curr_calibration); | ||
| if (_curr_calibration.size() != sizeof(ds::table_header) && // First time setting table, only header set by get_calibration_table |
There was a problem hiding this comment.
Is _curr_calibration here is same as in d500_debug_protocol_calibration_engine? Notice that d500_debug_protocol_calibration_engine::get_calibration_table still uses the member
There was a problem hiding this comment.
get_valibration_table remained in the engine, because it uses the debug protocol interface.
It gets the current_calibration as param - this is the same as the one used in the set_calibration_table method:
std::vector<uint8_t> d500_auto_calibrated::get_calibration_table() const
{
return _calib_engine->get_calibration_table(_curr_calibration);
}
OhadMeir
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.