context construction using make() #12498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Dec 7, 2023
maloel
force-pushed
the
factory-crash
branch
3 times, most recently
from
9148476 to
c40c4d6
Compare
maloel
force-pushed
the
factory-crash
branch
from
515eff9 to
3a0121b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following crash report from customer performing repeated dis/connects with device, while using callback that actually instantiates a pipeline inside (!! not recommended !!).
This makes the code more robust by switching to shared-ptr for contexts inside the factories.
Did the same for
device_hub, based on another report of crashes there, too...Tracked on [LRS-981]