Added class md_attribute_parser_with_crc to dev #12424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviaAv
force-pushed
the
md_attribute_parser_with_crc-to-dev
branch
2 times, most recently
from
7111633 to
fb6cf8b
Compare
offsetof replaced with variable
AviaAv
force-pushed
the
md_attribute_parser_with_crc-to-dev
branch
from
fb6cf8b to
653da4b
Compare
Nir-Az
reviewed
Dec 18, 2023
|
|
||
| if (!is_crc_valid(s)) | ||
| { | ||
| LOG_DEBUG("Metadata CRC mismatch"); |
There was a problem hiding this comment.
This is the way it was originally, and it is also LOG_DEBUG in the parent class in is_attribute_valid function, when we find "metadata mismatch"
Nir-Az
reviewed
Dec 18, 2023
| { | ||
| Attribute crc = *(Attribute*)(reinterpret_cast<const uint8_t*>(md_info) + _crc_offset); //Attribute = CRC's type (ex. uint32_t) | ||
| auto computed_crc32 = rsutils::number::calc_crc32(reinterpret_cast<const uint8_t*>(md_info), | ||
| sizeof(S) - sizeof(crc)); |
There was a problem hiding this comment.
What is this for?
sizeof(S) - sizeof(crc));?
There was a problem hiding this comment.
S is the struct that have all of the attributes, including the crc.
So we pass the size of all other attributes as a buffer for calc_crc32
Nir-Az
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-961]