removed width restriction for fw version #12355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Nov 5, 2023
common/device-model.cpp
Outdated
| std::string label = rsutils::string::from() << "##" << id << " " << pair.first; | ||
| if (pair.first == "Firmware Version") | ||
| { | ||
| fw_version = pair.second; |
There was a problem hiding this comment.
Please check if this parametes are used:
std::string fw_version;
std::string min_fw_version;
If not we can remove them ?
AviaAv
force-pushed
the
fw-version-short-rsviewer
branch
from
23b4ab8 to
a15b044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on RSDEV-1032