Fix static-analysys issue in frame_holder #12195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When fixing Coverity issues, please mention the issue IDs that are being addressed. |
Nir-Az
changed the title
|
The PR was not ready for review - I waiting for results from Coverity... |
OhadMeir
reviewed
Sep 19, 2023
src/sync.cpp
Outdated
| { | ||
| std::vector<frame_holder> match; | ||
| std::stringstream error_message_holder; | ||
| error_message_holder << f; // Saving frame holder string before moving frame |
There was a problem hiding this comment.
Please rename to frame_string_for_logging
There was a problem hiding this comment.
I assume it is done?
@Tamir91 when you update according to a comment please add a "Done" comment
There was a problem hiding this comment.
I assume it is done? @Tamir91 when you update according to a comment please add a "Done" comment
Yes, I talked with Ohad offline about changes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Coverity issues:
3413352 - Using moving object