Skip to content

Fix building with -DBUILD_EASYLOGGINGPP=OFF #11962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix building with -DBUILD_EASYLOGGINGPP=OFF #11962

merged 2 commits into from
Jul 6, 2023

Conversation

@Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Jul 3, 2023

Fix #11905

Tracked on [LRS-829]

@Nir-Az Nir-Az requested a review from OhadMeir July 3, 2023 13:44
OhadMeir
OhadMeir reviewed Jul 4, 2023
View reviewed changes
.github/workflows/buildsCI.yaml Outdated

#--------------------------------------------------------------------------------
Win_SH_EX_CfU: # Windows, shared, with Examples & Tools, and Check for Updates
Win_SH_EX_CfU: # Windows, shared, with Examples & Tools, no EasyLogging and Check for Updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to check on Linux?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's at the application level I thought it's enough to test on 1 OS, you think Linux is needed too?
We can add..

@maloel
Copy link
Contributor

maloel commented Jul 4, 2023

Why did we also change terminal-parser?

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Jul 4, 2023

Why did we also change terminal-parser?

When you added #include <rsutils/string/from.h> you removed the iostream include.
This file had std::cout inside.

It worked because easylogging include it somewhere, without it it was missing and we don't check it so you missed it.

I checked and the cout was redundant, so instead of reverting the removal of include iostream, I removed the cout.

@maloel
Copy link
Contributor

maloel commented Jul 4, 2023

I checked and the cout was redundant

How is it redundant? I don't see other code that outputs it...
But if you're convinced then OK.

@Nir-Az Nir-Az force-pushed the fix_ezlog branch 3 times, most recently from 7ce9ec6 to 1c5167d Compare July 6, 2023 10:07
@Nir-Az Nir-Az requested a review from OhadMeir July 6, 2023 11:38
OhadMeir
OhadMeir approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 7b4adcc into IntelRealSense:development Jul 6, 2023
@Nir-Az Nir-Az mentioned this pull request Jul 6, 2023
Closed
@Nir-Az Nir-Az deleted the fix_ezlog branch September 30, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nir-Az @maloel @OhadMeir