Skip to content

Conversation

@maloel
Copy link
Contributor

@maloel maloel commented Mar 26, 2023

This adds 2 more jobs (one Windows, one Linux), but improves total runtime by ~10 minutes:
On Linux, 35 minutes (Shared) -> down to 25 (Static)
On Windows, 44 minutes (Static) -> down to 27 (Shared with DDS) and 34 (Static, without DDS - with executables)

The unit-test executables really hurt.

@maloel maloel requested a review from Nir-Az March 26, 2023 10:35
@Nir-Az
Copy link
Collaborator

Nir-Az commented Mar 27, 2023

CI failed..

@maloel
Copy link
Contributor Author

maloel commented Mar 29, 2023

CI failed..

Not in our code, and I haven't changed any C++ code...

[100%] Linking CXX shared library pyrealsense2.cpython-38-x86_64-linux-gnu.so
lto1: internal compiler error: in add_symbol_to_partition_1, at lto/lto-partition.c:153
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-9/README.Bugs> for instructions.
lto-wrapper: fatal error: /usr/bin/c++ returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed

I'll rebase and try again, don't know what's causing this.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Mar 29, 2023

CI failed..

Not in our code, and I haven't changed any C++ code...

[100%] Linking CXX shared library pyrealsense2.cpython-38-x86_64-linux-gnu.so
lto1: internal compiler error: in add_symbol_to_partition_1, at lto/lto-partition.c:153
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-9/README.Bugs> for instructions.
lto-wrapper: fatal error: /usr/bin/c++ returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed

I'll rebase and try again, don't know what's causing this.

Looks like we have issues compiling on newer compilers..
Link Time Optimization issues.
Setting the compiler as GCC7 works but I'm not sure it's the right solution
Checking..

@Nir-Az
Copy link
Collaborator

Nir-Az commented Mar 29, 2023

My PR is ready but it will conflict with yours
#11627
It should fix the errors you see.
Should I merge first? (You will have to do the same as I did for your new builds)

@maloel
Copy link
Contributor Author

maloel commented Mar 30, 2023

My PR is ready but it will conflict with yours #11627

I don't see that it would conflict, you just changed the _LiveTests steps, no?
You do yours first, I'll update if needed.

sudo apt-get install -qq libusb-1.0-0-dev;
sudo apt-get install -qq libgtk-3-dev;
#sudo apt-get install gcc-5 g++-5;
#sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-5 60 --slave /usr/bin/g++ g++ /usr/bin/g++-5;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest aligning the compiler to GCC7 like in other U20 builds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thx

@maloel maloel mentioned this pull request Apr 2, 2023
@maloel maloel merged commit e99c69d into IntelRealSense:development Apr 2, 2023
@maloel maloel deleted the gha branch April 2, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants