-
Couldn't load subscription status.
- Fork 4.9k
split _CI GHA into two to save on time #11616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI failed.. |
Not in our code, and I haven't changed any C++ code... I'll rebase and try again, don't know what's causing this. |
Looks like we have issues compiling on newer compilers.. |
|
My PR is ready but it will conflict with yours |
I don't see that it would conflict, you just changed the |
.github/workflows/buildsCI.yaml
Outdated
| sudo apt-get install -qq libusb-1.0-0-dev; | ||
| sudo apt-get install -qq libgtk-3-dev; | ||
| #sudo apt-get install gcc-5 g++-5; | ||
| #sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-5 60 --slave /usr/bin/g++ g++ /usr/bin/g++-5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest aligning the compiler to GCC7 like in other U20 builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thx
This adds 2 more jobs (one Windows, one Linux), but improves total runtime by ~10 minutes:
On Linux, 35 minutes (Shared) -> down to 25 (Static)
On Windows, 44 minutes (Static) -> down to 27 (Shared with DDS) and 34 (Static, without DDS - with executables)
The unit-test executables really hurt.