-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Utilities rename #11186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilities rename #11186
Conversation
|
|
|
|
|
|
||
| using namespace utilities::time; | ||
| using namespace rsutils::time; // from rsutils/ | ||
| using namespace utilities::time; // from common/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 2 time classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not two classes.
We had one namespace, and the stuff in common/ added to it.
I didn't touch common/, so it stayed in the utilities namespace, while the stuff in rsutils moved.
common/ adds device-specific (L500 mainly) logic, which doesn't belong in rsutils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.. I must say it's confusing.
I can and I will. |
This is on purpose, at least in part -- here we need to override global mechanisms. Still, I'll take a look later. |
On the next one :) |
|
Thankyousir |
utilities->rsutils(project, paths, namespaces)utilities-pylibrealsense::to_string()(out of types.h) andrs2::to_string()(out of rendering.h) and move intorsutils::string::from()