Skip to content

Conversation

@npolina4
Copy link
Contributor

@npolina4 npolina4 commented Feb 5, 2024

Fix dpnp.asfortranarray and dpnp.ascontiguousarray functions for not array input. Add tests

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 !

Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @npolina4!

@npolina4 npolina4 merged commit 0987f19 into creation_funcs_docs Feb 5, 2024
@npolina4 npolina4 deleted the fix_ascontiguousarray branch February 5, 2024 21:15
npolina4 added a commit that referenced this pull request Feb 5, 2024
* Update docs for array creation functions

* fix pre-cimmit

* address comments

* address comments

* Add CFD examples and update CFD check for dpnp.copy

* Fix dpnp.asfortranarray and dpnp.ascontiguousarray functions for not array input (#1691)

* Fix dpnp.asfortranarray and dpnp.ascontiguousarray functions for not array input

* Fix tests
github-actions bot added a commit that referenced this pull request Feb 6, 2024
* Update docs for array creation functions

* fix pre-cimmit

* address comments

* address comments

* Add CFD examples and update CFD check for dpnp.copy

* Fix dpnp.asfortranarray and dpnp.ascontiguousarray functions for not array input (#1691)

* Fix dpnp.asfortranarray and dpnp.ascontiguousarray functions for not array input

* Fix tests 554bcdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants