Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Dec 12, 2023

The PR proposes to implement own alias template is_complex rather than relying on internal one from SYCL library, since it is from internal SYCL namespace, also it might have a limitation (for instance, latest DPC++ package for 2024.1 breaks dpnp compilation on Windows) and not indented initially to be used in host code.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 6c99e65 into master Feb 8, 2024
@antonwolfy antonwolfy deleted the dpnp_is_complex branch February 8, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants