Improve examples #390
Merged
Improve examples #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pretation of queue=None
Device selection examples added Sub-device creation examples added
oleksandr-pavlyk
requested review from
1e-to,
adarshyoga,
diptorupd and
reazulhoque
diptorupd
suggested changes
Apr 14, 2021
Contributor
diptorupd
left a comment
diptorupd
left a comment
There was a problem hiding this comment.
The device selection example functions are not being run anywhere in the example. Please fix that. Except for that we are golden.
Used run_examples routine implemented in _runner that support comand-line arguments, allows introspect available examples and run all of them, or any subset individually. E.g. ``` (idp) [09:37:14 nuc04 python]$ python subdevices.py -q --run subdivide_root_cpu_device cpu_d is a root device. Sub-device #EU: [4, 4, 4] Sub-device is_root: [False, False, False] Sub-device parent is what we expected: [True, True, True] Sub-sub-device #EU: [[1, 3], [1, 3], [1, 3]] ```
oleksandr-pavlyk
force-pushed
the
improve-examples
branch
from
472a371 to
8e44952
Compare
diptorupd
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modified Cython examples, as well as Python examples.
It add two files,
examples/python/device_selection.pyandexamples/python/subdevices.py.Please look them over, and suggest ideas for further examples.