Fix build break with GNU C++ compiler #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking build on GNU toolchain. Adding clean-up routine to remove empty strings fixes it.
diptorupd
approved these changes
Mar 25, 2021
diptorupd
pushed a commit
to diptorupd/dpctl
that referenced
this pull request
Mar 26, 2021
…gs (IntelPython#335) This was breaking build on GNU toolchain. Adding clean-up routine to remove empty strings fixes it.
diptorupd
pushed a commit
to diptorupd/dpctl
that referenced
this pull request
Mar 26, 2021
…gs (IntelPython#335) This was breaking build on GNU toolchain. Adding clean-up routine to remove empty strings fixes it.
diptorupd
pushed a commit
that referenced
this pull request
Apr 2, 2021
…gs (#335) This was breaking build on GNU toolchain. Adding clean-up routine to remove empty strings fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #327 were adding empty strigs to
compile_args,link_argswhich was breaking build on GNU toolchain,Adding clean-up routine to remove empty strings fixes it.