Skip to content

Add array-api-skips.txt for skipping select array API tests #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndgrigorian merged 1 commit into from
Jan 8, 2024
Merged

Add array-api-skips.txt for skipping select array API tests #1491

ndgrigorian merged 1 commit into from
Jan 8, 2024

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jan 5, 2024

This pull request adds array-api-skips.txt and modifies conda package workflow for array API testing. This skips array API tests for a linalg extension which has currently not been implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from c6c7f5d to 598d353 Compare January 5, 2024 23:27
@github-actions
Copy link

github-actions bot commented Jan 5, 2024

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1491/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jan 5, 2024 •
edited
Loading

Coverage Status

coverage: 89.693%. remained the same
when pulling 4e49412 on array-api-skip-linalg-tests
into 0a2a711 on master.

@github-actions
Copy link

github-actions bot commented Jan 5, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 0
Failed: 0
Skipped: 0

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 0
Failed: 0
Skipped: 0

@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from 598d353 to b6dfb34 Compare January 6, 2024 00:30
@ndgrigorian ndgrigorian changed the title Add array-api-skips.txt for skipping some array API tests Add array-api-skips.txt for skipping select array API tests Jan 6, 2024
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 0
Failed: 0
Skipped: 0

@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from b6dfb34 to 17e4742 Compare January 6, 2024 01:20
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 0
Failed: 0
Skipped: 0

@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from 17e4742 to ed7a682 Compare January 6, 2024 02:01
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 0
Failed: 0
Skipped: 0

@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from ed7a682 to a9d34ce Compare January 6, 2024 03:26
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 0
Failed: 0
Skipped: 0

@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from a9d34ce to 85ff10b Compare January 6, 2024 04:41
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 0
Failed: 0
Skipped: 0

@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from 85ff10b to 49c9e4e Compare January 6, 2024 05:42
@ndgrigorian ndgrigorian force-pushed the array-api-skip-linalg-tests branch from 49c9e4e to 4e49412 Compare January 6, 2024 06:53
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_55 ran successfully.
Passed: 875
Failed: 34
Skipped: 82

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, skipping known failures is a good idea. Makes it easier to see actual failures.

@ndgrigorian ndgrigorian merged commit f8b2202 into master Jan 8, 2024
@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Jan 26, 2024
Merged
6 tasks
@oleksandr-pavlyk oleksandr-pavlyk deleted the array-api-skip-linalg-tests branch February 2, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @oleksandr-pavlyk