Skip to content

Bug fix for standalone mod switch down for CKKS #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2025
Merged

Bug fix for standalone mod switch down for CKKS #110

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c03af2d
Bug fix for standalone mod switch for CKKS. Previous version of the c…
christopherngutierrez Jul 23, 2025
d51da2f
typo in comment
christopherngutierrez Jul 23, 2025
6ce79f8
Merge branch 'main' into christopherngutierrez/bugfix-ckks-standalone…
joserochh Jul 23, 2025
884a800
Merge branch 'main' into christopherngutierrez/bugfix-ckks-standalone…
joserochh Jul 23, 2025
e941384
Merge branch 'main' into christopherngutierrez/bugfix-ckks-standalone…
christopherngutierrez Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions p-isa_tools/kerngen/pisa_generators/mod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from high_parser import KernelContext, Immediate, HighOp, Polys

from .basic import (
Copy,
Add,
Sub,
Muli,
Expand Down Expand Up @@ -53,6 +54,12 @@ def to_pisa(self) -> list[PIsaOp]:
self.input0, self.context.current_rns
)

# For CKKS and standalone mod switch down, we can reduce the RNS by one and copy to output, no need to rescale
if self.context.scheme == "CKKS" and self.var_suffix == self.MOD_QLAST:
return mixed_to_pisa_ops(
[Copy(self.context, self.output, input_remaining_rns)]
)

# Temp.
temp_input_last_rns = duplicate_polys(input_last_rns, "y")
temp_input_remaining_rns = duplicate_polys(input_remaining_rns, "x")
Expand Down