Skip to content

Conversation

@zsol
Copy link
Contributor

@zsol zsol commented Jan 13, 2022

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 13, 2022
@zsol zsol linked an issue Jan 13, 2022 that may be closed by this pull request
Copy link
Contributor

@stroxler stroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than a formatting error (see line comment).

Thanks!

Co-authored-by: Steven Troxler <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #601 (3ebc626) into main (5f22b6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         244      244           
  Lines       24916    24916           
=======================================
  Hits        23602    23602           
  Misses       1314     1314           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f22b6c...3ebc626. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developer docs need to account for the native parser

4 participants