Skip to content

Conversation

@rhoerbe
Copy link
Contributor

@rhoerbe rhoerbe commented Aug 29, 2017

Not setting it makes a configuration to rare authentication failures if clocks are synchronized well below a second.

@c00kiemon5ter
Copy link
Member

I'm OK with this, eventhough this is relevant to pysaml2. The examples provided are not meant to be complete configurations. Users must configure their services as needed. Having sane example configs is nice to have anyway.

@jkakavas
Copy link
Member

LGTM, can you make a relevant PR to the pysaml2 repo examples (optimally a PR in the documentation too ) ?

@rhoerbe
Copy link
Contributor Author

rhoerbe commented Aug 30, 2017

I doubt that a zero slack time is a good default in pysaml2. It shouldbe at least 5s, if not more.

Still I would say that satosa users will take the local configuration example, not that form pysaml2. Therefore the default setting should be here.

@jkakavas
Copy link
Member

jkakavas commented Sep 1, 2017

I doubt that a zero slack time is a good default in pysaml2. It shouldbe at least 5s, if not more.

Still I would say that satosa users will take the local configuration example, not that form pysaml2. >Therefore the default setting should be here.

I didn't mean that it should be 0s. Also, I agree we should add it in the SATOSA examples but suggested we should add it to the pysaml idp/sp examples also.

@johanlundberg johanlundberg merged commit 95ea42f into IdentityPython:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants