Skip to content

replace ENTRYPOINT with CMD; EXPOSE port; + apt-get clean #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johanlundberg merged 3 commits into from
Sep 7, 2017
Merged

replace ENTRYPOINT with CMD; EXPOSE port; + apt-get clean #139

johanlundberg merged 3 commits into from
Sep 7, 2017

Conversation

@rhoerbe
Copy link
Contributor

@rhoerbe rhoerbe commented Aug 20, 2017

  • CMD allows docker runwith a shell; ENTRYPOINT is not suiteable here.-
  • For Docker orchestration tools it is good practice to export ports.
  • apt-get clean at the end of each run will make the layer lean.

@c00kiemon5ter
Copy link
Member

c00kiemon5ter commented Aug 21, 2017

LGTM

1 similar comment
@jkakavas
Copy link
Member

jkakavas commented Aug 23, 2017

LGTM

@jkakavas jkakavas self-requested a review September 6, 2017 12:48
@johanlundberg johanlundberg merged commit 989791e into IdentityPython:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkakavas jkakavas jkakavas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhoerbe @c00kiemon5ter @jkakavas @johanlundberg