Fix for no Format in NameIDPolicy for SAML2 frontend #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is acceptable SAML2 to have an <AuthnRequest> with a <NameIDPolicy> that includes the AllowCreate attribute but that does not include the Format attribute. When the SAML2 frontend receives such a request it should default to the metadata for the SP to determine which Format the SP requires. Before this commit SATOSA would ignore the SP metadata in such a case and use a transient format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #101
It is acceptable SAML2 to have an with
a that includes the AllowCreate attribute but
that does not include the Format attribute. When the SAML2
frontend receives such a request it should default to the
metadata for the SP to determine which Format the SP requires.
Before this commit SATOSA would ignore the SP metadata in such
a case and use a transient format.