Fix form field suggestions #2840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
does not work for notifications on a first test |
raviks789
force-pushed
the
fix/form-field-suggestion
branch
from
3e561a2 to
6cbb9ec
Compare
Collaborator
Author
As discussed offline, this is a fix for the bug where the data fields are not available for selection when a check command is not selected (Not a feature to show the custom properties of notification command in the notifications form). |
raviks789
force-pushed
the
fix/form-field-suggestion
branch
2 times, most recently
from
3c9169f to
7001316
Compare
|
works and has helped me to get the job done |
nilmerg
requested changes
Jan 9, 2024
raviks789
force-pushed
the
fix/form-field-suggestion
branch
3 times, most recently
from
f8ebda1 to
6f593d3
Compare
nilmerg
requested changes
Jan 12, 2024
raviks789
force-pushed
the
fix/form-field-suggestion
branch
9 times, most recently
from
7d96a36 to
ff470b1
Compare
Other available fields should be suggested when no check command has been chosen for service template.
raviks789
force-pushed
the
fix/form-field-suggestion
branch
from
ff470b1 to
1ec1698
Compare
nilmerg
requested changes
Jan 16, 2024
raviks789
force-pushed
the
fix/form-field-suggestion
branch
from
1ec1698 to
8a1588f
Compare
raviks789
force-pushed
the
fix/form-field-suggestion
branch
from
8a1588f to
1788d80
Compare
raviks789
force-pushed
the
fix/form-field-suggestion
branch
from
1788d80 to
80d566f
Compare
nilmerg
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other available fields should be suggested when no check command has been chosen for service template.
fixes #2826, #2815