-
Notifications
You must be signed in to change notification settings - Fork 115
feat: draw a range around draw-tools markers too #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Pull request artifacts
|
We can change the plugin name and description, but keep the same file name - then there won't be any problems when updating |
thanks for improving the code, it's quite clear i'm not really familiar with js and its code style :)
im mostly concerned about the plugin name in the hamburger menu on the top-right: if we change its name, will users that currently have selected "Wayfarer range" get the new plugin selected upon upgrade? |
Typo in title: s/arond/around/ |
Oh, also s/Spacial/Spatial/ in body. |
Co-Authored-By: Google Gemini
1acdd21
to
1e127f9
Compare
do you think this is ready to be merged? |
This is a bit of a complete rewrite, mostly done by Gemini (hence the tag at the bottom).
I'm considering renaming this plugin one Niantic Spatial releases the new submissions tool, but im a bit concerned about current users (if any, lol) and how the transition will go; i guess we still have more time to think about it
Co-Authored-By: Google Gemini