Skip to content

Conversation

sandrotosi
Copy link
Contributor

@sandrotosi sandrotosi commented Aug 9, 2025

This is a bit of a complete rewrite, mostly done by Gemini (hence the tag at the bottom).

I'm considering renaming this plugin one Niantic Spatial releases the new submissions tool, but im a bit concerned about current users (if any, lol) and how the transition will go; i guess we still have more time to think about it

Co-Authored-By: Google Gemini

Copy link

github-actions bot commented Aug 9, 2025

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk 1e127f9
test-0.40.0.20250812.051959.zip 1e127f9

See build on website

@sandrotosi
Copy link
Contributor Author

@modos189 since you reviewed #785

@modos189
Copy link
Contributor

modos189 commented Aug 9, 2025

I'm considering renaming this plugin one Niantic Spacial releases the new submissions tool, but im a bit concerned about current users (if any, lol) and how the transition will go; i guess we still have more time to think about it

We can change the plugin name and description, but keep the same file name - then there won't be any problems when updating

@sandrotosi
Copy link
Contributor Author

thanks for improving the code, it's quite clear i'm not really familiar with js and its code style :)

I'm considering renaming this plugin one Niantic Spacial releases the new submissions tool, but im a bit concerned about current users (if any, lol) and how the transition will go; i guess we still have more time to think about it

We can change the plugin name and description, but keep the same file name - then there won't be any problems when updating

im mostly concerned about the plugin name in the hamburger menu on the top-right: if we change its name, will users that currently have selected "Wayfarer range" get the new plugin selected upon upgrade?

@nexushoratio
Copy link
Contributor

Typo in title: s/arond/around/

@nexushoratio
Copy link
Contributor

Oh, also s/Spacial/Spatial/ in body.

@sandrotosi sandrotosi changed the title feat: draw a range arond draw-tools markers too feat: draw a range around draw-tools markers too Aug 12, 2025
@sandrotosi sandrotosi force-pushed the wayfarer-range-marker branch from 1acdd21 to 1e127f9 Compare August 12, 2025 05:19
@sandrotosi
Copy link
Contributor Author

do you think this is ready to be merged?

@modos189 modos189 merged commit 6d8fb4e into IITC-CE:master Sep 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants