Skip to content

regionscore: display CP minutes instead of '00' #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

regionscore: display CP minutes instead of '00' #799

merged 1 commit into from
Feb 18, 2025

Conversation

McBen
Copy link
Contributor

@McBen McBen commented Jan 29, 2025

closes #798

@github-actions GitHub Actions
Copy link

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk bab79be
test-0.39.1.20250129.221456.zip bab79be

See build on website

xscreach
xscreach approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@xscreach xscreach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but the changes look good

@McBen
Copy link
Contributor Author

McBen commented Jan 30, 2025 •
edited
Loading

FYI: setting time zone for testing:

  • chrome: developertools->dot-menue->more tools->sensors->set location and/or timezone
    (choose "mumbai" for half-hours times examples)
  • firefox: something with set TZ=utc before starting the browser..but I didn't checked it further

@Budgiebrain994
Copy link

Screenshot_20250217_112707_IITC Mobile Test

I'm in a half-hour timezone. LGTM on mobile.

Thanks for this change. It's been bugging me for over 10 years.

@modos189 modos189 merged commit e3863e2 into IITC-CE:master Feb 18, 2025
4 checks passed
@McBen McBen deleted the patch-3 branch March 15, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@xscreach xscreach xscreach approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Next CP" is incorrect for timezones with half hour time offsets.
4 participants
@McBen @Budgiebrain994 @xscreach @modos189