Skip to content

improve perf IcelandicFormatter #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2024
Merged

improve perf IcelandicFormatter #1394

merged 1 commit into from
Feb 17, 2024

Conversation

SimonCropp
Copy link
Collaborator

@SimonCropp SimonCropp commented Feb 17, 2024 •
edited
Loading

  • avoid string alloc of nextWord.Substring(0, 1));
  • avoid alloc of resourceString.Split(' ');
  • avoid the redundant array alloc in FormatWith

@SimonCropp SimonCropp enabled auto-merge (squash) February 17, 2024 09:01
@SimonCropp SimonCropp merged commit 40eaf42 into main Feb 17, 2024
@SimonCropp SimonCropp deleted the improve-perf-IcelandicFormatter branch February 17, 2024 09:06
@SimonCropp SimonCropp added this to the v3.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
perf
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SimonCropp