-
Couldn't load subscription status.
- Fork 3.1k
fix: TRIAG-1357: Hotkey not working for Number Tag #7746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
robot-ci-heartex
merged 1 commit into
develop
from
fb-triag-1357/hotkey-not-working-for-number-tag
Jun 12, 2025
Merged
fix: TRIAG-1357: Hotkey not working for Number Tag #7746
robot-ci-heartex
merged 1 commit into
develop
from
fb-triag-1357/hotkey-not-working-for-number-tag
Jun 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yyassi-heartex
approved these changes
Jun 12, 2025
hlomzik
reviewed
Jun 12, 2025
hlomzik
reviewed
Jun 12, 2025
hlomzik
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hotkeys are not working properly for input number elements.
The origin of the problem is that the method falls back to 0 when max is not defined. But when working on it, I realized that the
increaseValuemethod does not:As extreme scenario to consider. min=.1 max=.7 step=.1 defaultvalue=.5
A better fix would likely be to sanitize the value when the tag is created. However, since I couldn't identify the pattern and it appears that only this isolated method is affected, I decided not to overcomplicate the component.
tested on cases like:
@hlomzik can you take a look to this?