You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request updates the Toggle component in web/libs/ui/src/lib/toggle/toggle.tsx to improve performance and maintainability by introducing the useCallback hook for the onChange handler. The most important changes are summarized below:
Ultimatly this allows us to undo a toggle from the parent if needed
Performance Improvement:
Introduced useCallback for onChange handler: Added a memoized onChangeHandler function using useCallback to optimize re-renders and ensure consistent function references.
Code Simplification:
Replaced inline onChange logic with onChangeHandler: Updated the onChange prop of the input element to use the new onChangeHandler function, replacing the previous inline logic.
Dependency Updates:
Updated imports to include useCallback: Added useCallback to the list of imported hooks from React.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Togglecomponent inweb/libs/ui/src/lib/toggle/toggle.tsxto improve performance and maintainability by introducing theuseCallbackhook for theonChangehandler. The most important changes are summarized below:Ultimatly this allows us to undo a toggle from the parent if needed
Performance Improvement:
useCallbackforonChangehandler: Added a memoizedonChangeHandlerfunction usinguseCallbackto optimize re-renders and ensure consistent function references.Code Simplification:
onChangelogic withonChangeHandler: Updated theonChangeprop of the input element to use the newonChangeHandlerfunction, replacing the previous inline logic.Dependency Updates:
useCallback: AddeduseCallbackto the list of imported hooks from React.