Skip to content

Conversation

@matt-bernstein
Copy link
Contributor

Longstanding bug uncovered during QA for recent multitask JSON support. When >2 tasks in a set of duplicates have storage links, a RuntimeError is raised instead of ignoring the extra storage links as intended.

…Remove Duplicated Tasks action for specific number of storage imported tasks
@matt-bernstein matt-bernstein requested a review from a team as a code owner May 28, 2025 19:20
@matt-bernstein matt-bernstein removed the request for review from a team May 28, 2025 19:20
@netlify
Copy link

netlify bot commented May 28, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit 61b0ef0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/683896a16ad02b0008459a43

@matt-bernstein matt-bernstein requested a review from makseq May 28, 2025 19:20
@github-actions github-actions bot added the fix label May 28, 2025
@netlify
Copy link

netlify bot commented May 28, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 61b0ef0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/683896a1d99da50008f979fc

@netlify
Copy link

netlify bot commented May 28, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 61b0ef0
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/683896a1ab050700082efab3

@netlify
Copy link

netlify bot commented May 28, 2025

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit 61b0ef0
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/683896a1392bff00087112af

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (2616ab9) to head (61b0ef0).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7642   +/-   ##
========================================
  Coverage    78.49%   78.50%           
========================================
  Files          197      197           
  Lines        16008    16010    +2     
========================================
+ Hits         12565    12568    +3     
+ Misses        3443     3442    -1     
Flag Coverage Δ
pytests 78.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@makseq
Copy link
Member

makseq commented May 29, 2025

@matt-bernstein Please QA it thoroughly; the logic here is twisted..

@matt-bernstein
Copy link
Contributor Author

matt-bernstein commented May 29, 2025

/git merge develop

Workflow run
Successfully merged: rename web/libs/{datamanager/src => core/src/lib}/utils/urlJSON.ts (100%)

@matt-bernstein
Copy link
Contributor Author

matt-bernstein commented May 29, 2025

/fm sync

Workflow run

Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@matt-bernstein
Copy link
Contributor Author

matt-bernstein commented May 29, 2025

/git merge develop

Workflow run
Successfully merged: 4 files changed, 21 insertions(+), 3 deletions(-)

@matt-bernstein
Copy link
Contributor Author

matt-bernstein commented May 29, 2025

/fm sync

Workflow run

@matt-bernstein
Copy link
Contributor Author

matt-bernstein commented May 29, 2025

/fm merge

Command Description
/fm sync Sync upstream prs and merge with pull request base

@robot-ci-heartex robot-ci-heartex merged commit eb71bcf into develop May 29, 2025
52 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-ROOT-26 branch May 29, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants