Skip to content

fix: FIT-126: datamanager column resizer positioning fix #7577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025
Merged

fix: FIT-126: datamanager column resizer positioning fix #7577

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67a2839
fix: FIT-126: datamanager column resizer positioning fix
yyassi-heartex May 15, 2025
42f4122
Merge branch 'develop' into fb-fit-126/resizer
yyassi-heartex May 20, 2025
714a7f3
addressing size of resizer used on labeling page
yyassi-heartex May 20, 2025
b10eac8
Merge remote-tracking branch 'origin/develop' into fb-fit-126/resizer
yyassi-heartex May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 8 additions & 26 deletions web/libs/datamanager/src/components/Common/Resizer/Resizer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
.resizer {
--handle-size: 1px;
--handle-size-hover: 2px;

position: relative;
--handle-size: 2px;
--handle-size-hover: 3px;

& button {
&:focus {
Expand All @@ -12,33 +10,17 @@
}

&__handle {
top: 0;
height: 100%;
top: 25%;
bottom: 25%;
position: absolute;
cursor: ew-resize;
z-index: 100;
right: 0;
width: var(--handle-size);
background: var(--color-neutral-border);

&::before {
top: 0;
left: 50%;
bottom: 0;
width: var(--handle-size);
content: "";
z-index: 5;
display: block;
background: var(--color-neutral-border);
position: absolute;
}

&_quickview::before {
left: 0;
}

&:hover::before,
&_resizing::before {
top: 0;
bottom: 0;
&:hover,
&_resizing {
width: var(--handle-size-hover);
background-color: var(--color-primary-border-subtle);
}
Expand Down
1 change: 0 additions & 1 deletion web/libs/datamanager/src/components/Common/Table/Table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@
display: flex;
align-items: center;
position: relative;
overflow: hidden;
word-break: break-word;
color: var(--color-neutral-content-subtler);
}
Expand Down
1 change: 0 additions & 1 deletion web/libs/datamanager/src/components/Common/TableOld/Table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@
display: flex;
align-items: center;
position: relative;
overflow: hidden;
word-break: break-word;
}

Expand Down
5 changes: 5 additions & 0 deletions web/libs/datamanager/src/components/Label/Label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
flex: 200px 0 0;
position: relative;
flex-direction: column;

.resizer__handle {
top: 0;
bottom: 0;
}
}

&__content {
Expand Down
5 changes: 5 additions & 0 deletions web/libs/datamanager/src/utils/feature-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ export const FF_MEMORY_LEAK_FIX = "fflag_feat_all_optic_1178_reduce_memory_leak_
*/
export const FF_REGION_VISIBILITY_FROM_URL = "fflag_feat_front_optic_1553_url_based_region_visibility_short";

/**
* Add ability to show average agreement score popover in Agreement cell.
*/
export const FF_AVERAGE_AGREEMENT_SCORE_POPOVER = "fflag_feat_all_leap_2042_average_agreement_score_popover";

// Customize flags
const flags = {};

Expand Down
2 changes: 1 addition & 1 deletion web/libs/editor/src/regions/PolygonPoint.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState } from "react";
import { Circle, Rect } from "react-konva";
import { observer } from "mobx-react";
import { getParent, getRoot, hasParent, types } from "mobx-state-tree";
import { getParent, hasParent, types } from "mobx-state-tree";

import { RELATIVE_STAGE_HEIGHT, RELATIVE_STAGE_WIDTH } from "../components/ImageView/Image";
import { guidGenerator } from "../core/Helpers";
Expand Down
2 changes: 1 addition & 1 deletion web/libs/editor/src/regions/TimeSeriesRegion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as d3 from "d3";
import { getRoot, types } from "mobx-state-tree";
import { types } from "mobx-state-tree";

import { Hotkey } from "../core/Hotkey";
import NormalizationMixin from "../mixins/Normalization";
Expand Down
2 changes: 1 addition & 1 deletion web/libs/editor/src/regions/VideoRegion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getRoot, types } from "mobx-state-tree";
import { types } from "mobx-state-tree";

import { guidGenerator } from "../core/Helpers";
import { AreaMixin } from "../mixins/AreaMixin";
Expand Down
Loading