feat: OPTIC-1938: Proxy for storages when presigned urls are off #7354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
|
/fm sync |
…nto fb-optic-1938
jombooth
reviewed
Apr 17, 2025
jombooth
reviewed
Apr 17, 2025
jombooth
reviewed
Apr 17, 2025
jombooth
reviewed
Apr 17, 2025
|
overall LG (and very impressive work), biggest concerns are whether we've introduced S3 specific details to code that's used for other storages as well, as in #7354 (comment) |
|
/fm sync |
…nto fb-optic-1938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage proxy added
Our current implementation with presigned urls:
This PR adds proxying from storages instead of redirecting to presigned urls:
Minor fixes
Fixed race condition on Project => Settings => Cloud Storages page when project=undefined on the first page loading.