-
Couldn't load subscription status.
- Fork 3.1k
fix: OPTIC-1785: Validate S3 bucket name on storage connection form #7183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ating bucket name in serializer
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7183 +/- ##
===========================================
- Coverage 77.32% 77.31% -0.02%
===========================================
Files 188 188
Lines 14581 14586 +5
===========================================
+ Hits 11275 11277 +2
- Misses 3306 3309 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/fm sync |
This pull request introduces a mixin class to handle common functionality for S3 storage serializers and refactors existing serializers to use this mixin. The most important changes include the creation of the
S3StorageSerializerMixin, the addition of a bucket name validation method, and the refactoring ofS3ImportStorageSerializerandS3ExportStorageSerializerto use the new mixin.Refactoring and code reuse:
S3StorageSerializerMixinto encapsulate common functionality for S3 storage serializers, including secure field handling and bucket name validation.S3ImportStorageSerializerto inherit fromS3StorageSerializerMixinandImportStorageSerializer, consolidating common code and adding thepresignfield.S3ExportStorageSerializerto inherit fromS3StorageSerializerMixinandExportStorageSerializer, consolidating common code.Validation improvements:
validate_bucketmethod toS3StorageSerializerMixinto validate the bucket name usingvalidate_bucket_namefrombotocore.handlers.Code simplification:
S3ImportStorageSerializer.secure_fieldswithself.secure_fieldsto simplify code and improve maintainability.Screen.Recording.2025-03-07.at.14.34.33.mov