Skip to content

fix: LEAP-1892: [FE] Deeply nested Choices are visible when their parents are hidden #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 14, 2025
Merged

fix: LEAP-1892: [FE] Deeply nested Choices are visible when their parents are hidden #7180

merged 13 commits into from
Mar 14, 2025

Conversation

@nass600
Copy link
Contributor

@nass600 nass600 commented Mar 7, 2025 •
edited
Loading

Issue: Linked components were not applying correctly the visibility of their relations
conditional-choices-bug

After fix:
Level 3 should be hidden given it depends on Level 2 which is hidden as a consequence from being linked to level 1
conditional-choices-fixed

@nass600 nass600 requested review from Gondragos and hlomzik March 7, 2025 11:53
@github-actions github-actions bot added the fix label Mar 7, 2025
@netlify
Copy link

netlify bot commented Mar 7, 2025 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit d41921a
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67d3dcab2fa471000897645e

@netlify
Copy link

netlify bot commented Mar 7, 2025 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit d41921a
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67d3dcabf378400007a5560f

@nass600 nass600 marked this pull request as draft March 7, 2025 12:02
@nass600 nass600 marked this pull request as ready for review March 7, 2025 14:30
@nass600 nass600 force-pushed the fb-leap-1892/deeply-nested-choices branch from 5f5f089 to 31baf75 Compare March 10, 2025 10:09
@nass600
Copy link
Contributor Author

nass600 commented Mar 10, 2025

@Gondragos @hlomzik this PR is ready for review again

@hlomzik hlomzik requested a review from Gondragos March 10, 2025 10:46
hlomzik
hlomzik reviewed Mar 10, 2025
View reviewed changes
@nass600
Copy link
Contributor Author

nass600 commented Mar 10, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/lib/enterprise-badge/enterprise-badge.tsx

Gondragos
Gondragos reviewed Mar 10, 2025
View reviewed changes
@nass600
Copy link
Contributor Author

nass600 commented Mar 12, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: delete mode 100644 label_studio/templates/401.html

@nass600
Copy link
Contributor Author

nass600 commented Mar 12, 2025 •
edited
Loading

As per discussed with @hlomzik, we are leaving out of the scope of this bug the perregion and choice-unselected use cases given they are not affected by the fix and they need some extra thorough analysis. cc: @Gondragos

hlomzik
hlomzik reviewed Mar 12, 2025
View reviewed changes
@MihajloHoma
Copy link
Contributor

MihajloHoma commented Mar 14, 2025 •
edited by robot-ci-heartex
Loading

/git merge

Workflow run
Successfully merged: delete mode 100644 web/libs/editor/src/components/Timeline/Controls/Info.tsx

@MihajloHoma
Copy link
Contributor

MihajloHoma commented Mar 14, 2025 •
edited by robot-ci-heartex
Loading

/fm sync

Workflow run

@nass600 nass600 merged commit 52e941a into develop Mar 14, 2025
34 checks passed
@hlomzik hlomzik mentioned this pull request Jun 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hlomzik hlomzik hlomzik approved these changes

+1 more reviewer

@Gondragos Gondragos Gondragos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Confirmed fix FM Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nass600 @MihajloHoma @hlomzik @Gondragos @robot-ci-heartex