Skip to content

Conversation

@westhyena
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

#4421

In airgapped environment, frontend tries to get the file from sentry cdn, but it hangs, so page won't load.
Setting FRONTEND_SENTRY_DSN won't fix this problemn.

What does this fix?

When FRONTEND_SENTRY_DSN is set empty,
it disables

  • sentry initialization
  • fetching from sentry cdn

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

@netlify
Copy link

netlify bot commented Nov 8, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bb80f7b

@netlify
Copy link

netlify bot commented Nov 8, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bb80f7b

@github-actions github-actions bot added the feat label Nov 8, 2024
@westhyena westhyena requested a review from bmartel November 11, 2024 03:40
@robot-ci-heartex
Copy link
Collaborator

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@robot-ci-heartex
Copy link
Collaborator

This PR was closed because it has been stalled for 10 days with no activity.

@bmartel bmartel reopened this Feb 13, 2025
@bmartel bmartel removed the Stale label Feb 13, 2025
@bmartel
Copy link
Contributor

bmartel commented Feb 13, 2025

/git merge develop

Workflow run
Successfully merged: Already up to date.

@bmartel bmartel merged commit 560e330 into HumanSignal:develop Feb 13, 2025
22 of 34 checks passed
bmartel added a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants