fix: LEAP-1363: View all is loading even when value is empty for RichText #6190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jombooth
reviewed
Aug 12, 2024
jombooth
approved these changes
Aug 12, 2024
hlomzik
requested changes
Aug 13, 2024
MihajloHoma
approved these changes
Aug 13, 2024
hlomzik
approved these changes
Aug 14, 2024
|
/git merge develop
|
|
/git merge develop
|
|
/git merge develop
|
we need to distinguish an empty string from non loaded state, for that we add ability to have null _value
hlomzik
approved these changes
Aug 19, 2024
|
/git merge develop
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
When user is using a config with text, and uploading the data with no value for the text, the RichText tag is not loading and the prop isReady is not set to true, so when user clicks on
View all Annotationsview, it's not loading the taskWhat does this fix?
Just changes the validation from
!this_valuefor!this._value === nullso even if the value is empty but the data is correct and value exists, it's loading the tag and setting isReady to true when it's ready.