Skip to content

fix: DEV-3473: Making exc_info None when debug_modal_exceptions_false #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix: DEV-3473: Making exc_info None when debug_modal_exceptions_false #3128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion label_studio/core/utils/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def custom_exception_handler(exc, context):
logger.debug(exc_tb)
response_data['detail'] = str(exc)
if not settings.DEBUG_MODAL_EXCEPTIONS:
exc_tb = 'Tracebacks disabled in settings'
exc_tb = None
response_data['exc_info'] = exc_tb
response = Response(status=status.HTTP_500_INTERNAL_SERVER_ERROR, data=response_data)

Expand Down
2 changes: 1 addition & 1 deletion label_studio/tests/errors.tavern.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ stages:
response:
json:
detail: test
exc_info: Tracebacks disabled in settings
exc_info: ~
status_code: 500