- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.1k
fix: DEV-3397: Added session expiration settings and conditions #3114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    … on last login and last activity. Also made persistent session optional on login.
              
                    hakan458
  
              
              reviewed
              
                  
                    Oct 19, 2022 
                  
              
              
            
            
              
                    hakan458
  
              
              approved these changes
              
                  
                    Oct 19, 2022 
                  
              
              
            
            
              
                    MihajloHoma
  
              
              approved these changes
              
                  
                    Oct 27, 2022 
                  
              
              
            
            
| Codecov ReportBase: 77.30% // Head: 77.34% // Increases project coverage by  
 Additional details and impacted files@@             Coverage Diff             @@
##           develop    #3114      +/-   ##
===========================================
+ Coverage    77.30%   77.34%   +0.04%     
===========================================
  Files          147      147              
  Lines        10813    10837      +24     
===========================================
+ Hits          8359     8382      +23     
- Misses        2454     2455       +1     
 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Added session expiration settings and conditions based on last login and last activity. Also made persistent session optional on login.