Skip to content

Conversation

@KonstantinKorotaev
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2536 (770f00e) into develop (17b40da) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2536      +/-   ##
===========================================
- Coverage    77.80%   77.51%   -0.29%     
===========================================
  Files          137      141       +4     
  Lines         9951    10298     +347     
===========================================
+ Hits          7742     7983     +241     
- Misses        2209     2315     +106     
Impacted Files Coverage Δ
label_studio/label_studio/users/mixins.py 75.00% <0.00%> (-12.50%) ⬇️
...bel_studio/label_studio/organizations/functions.py 66.66% <0.00%> (-10.26%) ⬇️
...l_studio/label_studio/core/templatetags/filters.py 48.75% <0.00%> (-6.20%) ⬇️
label_studio/label_studio/users/api.py 80.45% <0.00%> (-3.88%) ⬇️
label_studio/label_studio/ml/serializers.py 92.30% <0.00%> (-2.43%) ⬇️
label_studio/label_studio/core/utils/contextlog.py 44.55% <0.00%> (-2.33%) ⬇️
label_studio/label_studio/tasks/serializers.py 84.27% <0.00%> (-2.27%) ⬇️
label_studio/label_studio/tasks/models.py 87.85% <0.00%> (-2.20%) ⬇️
...abel_studio/label_studio/data_manager/functions.py 64.70% <0.00%> (-1.97%) ⬇️
label_studio/label_studio/core/label_config.py 71.54% <0.00%> (-1.85%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1956b3b...770f00e. Read the comment docs.

emit_webhooks_for_instance(project.organization, project, WebhookAction.ANNOTATIONS_DELETED, annotations_ids)
start_job_async_or_sync(bulk_update_stats_project_tasks, queryset.filter(is_labeled=True))
start_job_async_or_sync(project.update_tasks_counters, queryset)
start_job_async_or_sync(project.update_tasks_counters, list(queryset))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we have 1m tasks here? they will be downloaded fully, but we can use only ids here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@KonstantinKorotaev KonstantinKorotaev marked this pull request as ready for review June 27, 2022 15:38
@KonstantinKorotaev KonstantinKorotaev merged commit 0ca8424 into develop Jun 27, 2022
@deppp deppp deleted the fb-DEV-2658 branch February 15, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants