Skip to content

chore: remove package.json from private app project #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2024
Merged

chore: remove package.json from private app project #32

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6af4f24
chore: remove potentially unreliable package.json scripts
banderson Aug 13, 2024
25d1e4a
Actually, let's just remove root-level package.json entirely
banderson Aug 16, 2024
de7ac31
Also remove package-lock
banderson Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions projects/private-app-getting-started-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would it be beneficial to remove this file entirely? Running npm install at the wrong directory level seemed to be a pretty common support issue, and the post install was mitigating this in at least some of the cases. Are there benefits to keeping this file around without the scripts block?

Copy link
Contributor Author

@banderson banderson Aug 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not agree more, @joe-yeager! I took a baby step to remove the fangs from this issue with this small change, but I am also happy if we go all the way and remove it!

"name": "hubspot-get-started-project",
"private": true,
"version": "0.1.0",
"description": "Basic example of a UI Extension built with HubSpot's React developer tools",
"scripts": {
"postinstall": "cd ./src/app/extensions/ && npm install && cd ../app.functions && npm install",
"build": "npm run build --prefix ./src/app/extensions/"
},
"author": "HubSpot",
"license": "MIT"
}