React getting started project #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor project config entries
…ubspot-project-components into UIE-public-beta-update
…ubspot-project-components into UIE-public-beta-update
fix: Remove package.lock from project templates
README updates
camden11
reviewed
Aug 15, 2023
There was a problem hiding this comment.
This works well and is more or less good to go! Two minor updates we might want to make before merging:
- Update the name of the empty project in
hsproject.jsonto match the changes to getting started project's name. Maybe "just "Empty Project"? (It's currently "no-template") - Should the empty project also have an MIT license or are its contents minimal enough that we can skip it?
camden11
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.