Skip to content

saoimageds9: deprecate unsigned #222455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

saoimageds9: deprecate unsigned #222455

merged 1 commit into from
Aug 4, 2025

Conversation

krehel
Copy link
Member

@krehel krehel commented Aug 2, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


@krehel
Copy link
Member Author

krehel commented Aug 2, 2025

Wondering how CI is thinking it is signed on macos-14. App is not signed. Upstream also refers to use xattr to adjust attributes.

saoimageds9 site

@bevanjkay
Copy link
Member

bevanjkay commented Aug 3, 2025

I don't think gktool is working correctly on the Sonoma runners, but we can't defer back to the other check, because it can be inconsistent with gktool.

@p-linnane p-linnane added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Aug 4, 2025
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not worth spending time debugging to disable this cask. I doubt we'll get any meaningful updates to gktool in Sonoma.

@p-linnane p-linnane enabled auto-merge August 4, 2025 15:52
@p-linnane p-linnane added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 66015af Aug 4, 2025
25 of 31 checks passed
@p-linnane p-linnane deleted the deprecate-saoimageds9 branch August 4, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cask disabled Cask disabled ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. unsigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants