Skip to content

Update physical constants #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2025
Merged

Update physical constants #1223

merged 6 commits into from
Apr 25, 2025

Conversation

@AlexanderSinn
Copy link
Member

Update physical constants to be the same as in WarpX from BLAST-WarpX/warpx#5661

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the unit system handling of both SI and normalized units options label Apr 1, 2025
@MaxThevenet MaxThevenet added the non-backward-compatible Changes the behavior of the code, old input file may give different results label Apr 25, 2025
MaxThevenet
MaxThevenet approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@MaxThevenet MaxThevenet merged commit f4c4a3c into Hi-PACE:development Apr 25, 2025
10 checks passed
EyaDammak added a commit to EyaDammak/hipace that referenced this pull request May 16, 2025
@EyaDammak @AlexanderSinn @MaxThevenet
Merge dev (#8)
9bb6ce7 
* Resize Beam Diagnostic buffer (Hi-PACE#1227)

* Fix shadow issue in AddGridExternalFields (Hi-PACE#1230)

* Update Ubuntu version of CI tests (Hi-PACE#1232)

* Remove CONDA from CUDA Local CI (Hi-PACE#1236)

* Beam read_from_file also reads spin (Hi-PACE#1172)

Co-authored-by: Alexander Sinn <[email protected]>

* Update physical constants (Hi-PACE#1223)

* Fix laser from file hanging with MPI (Hi-PACE#1235)

* Add Parser Debug Print Utility (Hi-PACE#1238)

* Fix CI with MPI (Hi-PACE#1241)

---------

Co-authored-by: Alexander Sinn <[email protected]>
Co-authored-by: Maxence Thévenet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees

No one assigned

Labels

non-backward-compatible Changes the behavior of the code, old input file may give different results unit system handling of both SI and normalized units options

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexanderSinn @MaxThevenet