Error when opening the shell

[bitsnaps]

For some reasons, the shell command is broken, I get this when running puter shell

❯ puter shell
file:///path/to/puter-cli/src/executor.js:159
  const [cmd, ...args] = input?input.split(' '):[];
                                     ^

TypeError: input.split is not a function

The input variable is an empty object here: {}.

Running puter alone ends with:

❯ puter
Welcome to Puter-CLI! Type "help" for available commands.
puter@bitsnaps/Documents> node:internal/event_target:1101
  process.nextTick(() => { throw err; });
                           ^

TypeError: Cannot read properties of undefined (reading 'unref')
    at ws.onopen (evalmachine.<anonymous>:4:87272)

then terminates the puter session.

I'm running node v22.18.0 on MacOS.

[reynaldichernando]

huh, for some reason this issue is not closed, even though we fixed it in #45

[bitsnaps]

@reynaldichernando How could you run the shell? is it random?

[reynaldichernando]

i don't get any issues when running just puter or node bin/index.js
but my PR for #45 did solve the input.split error specific to puter shell

[bitsnaps]

@reynaldichernando Yep, those are two different issues, I'm getting the last one in all cases (puter, puter shell and node bin/index.js). I think this issue appears in the previous merge (not in the latest one).

[reynaldichernando]

i see, i can't repro the error even on fresh install, could you reinstall it again and see if its still happening?

[reynaldichernando]

btw i just had a thought @bitsnaps , it's also possible it has something to do with your config.json (?)
seeing as this might vary from user to user

could you help share yours? obviously hiding the credentials

[bitsnaps]

@reynaldichernando That's interesting ! I tried to logout, delete my config.json then login again, and I'm still getting the same results:

{
        "profiles": [
                {
                        "host": "https://puter.com",
                        "username": "bitsnaps",
                        "cwd": "/bitsnaps",
                        "token": "<MY_PUTER_API_KEY>",
                        "uuid": "<MY_PROFILE_UUID>"
                }
        ],
        "selected_profile": "<MY_PROFILE_UUID>",
        "username": "bitsnaps",
        "cwd": "/bitsnaps"
}

I thought that maybe some old/conflicted key/values caused that issue, I still believe that this could be something with my machine btw, the node caching (I might need to clean/re-install dependencies).

[reynaldichernando]

hmm, my config.json looks exactly the same, so probably not config

I thought that maybe some old/conflicted key/values caused that issue, I still believe that this could be something with my machine btw, the node caching (I might need to clean/re-install dependencies).

alright, thank you, meanwhile i'll also try again on my end, see if i missed anything when trying to repro the issue

[bitsnaps]

@reynaldichernando I'm checking out to the most recent working (at least for me) commit in the master branch at #0280b5a just before we introduced the PuterModule module and getPuter() function.

[reynaldichernando]

hi @bitsnaps , i can confirm the issue is happening, so i've been working on node 20 this time, where the issue doesn't exist

• node 20 ✅
• node 22 ❌
• node 24 ❌

both 22 and 24 has the same unref issues

anyway, i managed to fix this in #52 , could you help try that PR?

[bitsnaps]

@reynaldichernando Awesome, #52 fixes this issue.

[reynaldichernando]

nice, btw for now if you want to try the v2 stuff, maybe you could try with node 20 first, since the change hasn't been included there yet