Skip to content

Issue with API server and autotraders on restart #3306

@guilherme-gm

Description

@guilherme-gm

Creating an issue for tracking this message from Dastgir in #3304; I will look into it

 Probably unrelated to this PR, but there's one more issue wherein API server is called for autotraders on restart, and we get bunch of Account not online errors

Originally posted by @dastgirp in #3304 (comment)

Describe the bug
If you have persistent autotraders and do have one or more autotraders during server startup, you get an error for each one:

[Error]: Cant set char online. Account not logged in: 2000003

To Reproduce
Steps to reproduce the behavior:

  1. Setup a vending
  2. @autotrade
  3. Shutdown your server ( ./athena-start stop )
  4. Start the server again ( ./athena-start start )
  5. See error in console

Expected behavior
Autotraders should not cause errors during startup.

Screenshots

System specs (please complete the following information):

  • OS: 5.15.153.1-microsoft-standard-WSL2 (Unix)
  • Hercules Version v2024.07 (master from this date -- no release yet)
  • Mode: any
  • Packet version: any
  • Client type: any

Plugins used or source modifications
None

Additional context
From what I can tell so far, this comes from the fact that during autotrader loading (which happens in map-server), it will send to char which will then send to login, finally sending the list to API server which won't recognize it.

I believe we should either:

  1. Not send to API
  2. Create accounts in API if they are coming from autotrade

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions