It is impossible to add a Zabbix server

[ogarcia]

Steps to reproduce:

1. Open nagstamon without previous configuration.
2. The program asks if you want to add a server. Click on “Create new server”.
3. Fill in the data and press OK.
4. After a few seconds the program crashes.

This happens both in the latest version and in the git master version.

Log:

$ nagstamon 
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
qt.multimedia.gstreamer: Using Qt multimedia with GStreamer version: "GStreamer 1.26.2"
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/Nagstamon/QUI/__init__.py", line 4085, in get_status
    status = self.server.get_status()
  File "/usr/lib/python3.13/site-packages/Nagstamon/Servers/Generic.py", line 925, in get_status
    status = self._get_status()
  File "/usr/lib/python3.13/site-packages/Nagstamon/Servers/Zabbix.py", line 372, in _get_status
    'host': service['hosts'][0]['host'],
            ~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range
Aborted (core dumped)

If at startup I tell it that I don't want to add server and I try to add it from the settings it also crashes, but the error is different:

$ nagstamon 
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
qt.multimedia.gstreamer: Using Qt multimedia with GStreamer version: "GStreamer 1.26.2"
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
QLayout: Attempting to add QLayout "" to StatusWindow "", which already has a layout
(<class 'AttributeError'>, AttributeError("'NoneType' object has no attribute 'maintenance'"), <traceback object at 0x7f5980660bc0>)
Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/Nagstamon/QUI/__init__.py", line 4085, in get_status
    status = self.server.get_status()
  File "/usr/lib/python3.13/site-packages/Nagstamon/Servers/Generic.py", line 925, in get_status
    status = self._get_status()
  File "/usr/lib/python3.13/site-packages/Nagstamon/Servers/Zabbix.py", line 157, in _get_status
    services = self.zapi.trigger.get({'only_true': True,
               ^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'trigger'
Aborted (core dumped)

[HenriWahl]

Which version of Nagstamon do you use? Maybe #1107 might be of help for you.

[ogarcia]

Which version of Nagstamon do you use? Maybe #1107 might be of help for you.

This happens both in the latest version and in the git master version.

The Zabbix I am using is a Zabbix 5 so it looks like a different bug.

[Simkimdm]

Hi @ogarcia Zabbix 5 is unsupported by Zabbix itself so we also removed the support from Nagstamon. Is it possible for you to update Zabbix to a later version?

[ogarcia]

In my case it is not possible because it is a company Zabbix. But that's ok, if it's not compatible there's not much you can do, maybe it would be a good idea that instead of shutting down and crashing it would just show a message saying which is the minimum version it supports?

[millnet-maho]

The second crash happens to me too with Zabbix 7.0.9 and Nagstamon 3.16.2 (both via Debian; bookworm and trixie, respectively). Maybe I'm not configuring authentication correctly, but the application nonetheless shouldn't crash.

I might add that files exist and are created in ~/.zabbix/servers, but Nagstamon still says that no servers are configured on startup.

[millnet-maho]

What's this in thirdparty/zabbix_api.py?
auth = 'Basic ' + string.strip(base64.encodestring(self.httpuser + ':' + self.httppasswd))

string.strip is not a function. Shouldn't that line read
auth = 'Basic ' + base64.encodestring(self.httpuser + ':' + self.httppasswd).strip()
?

Actually, that line is never run, because httpuser and httppasswd aren't set by Servers.Zabbix, but maybe it's a good idea to correct it anyway.

[millnet-maho]

I think my problem was that TLS validation failed (due to our internal root certificate's CA constraint being marked as critical). That causes the self.get_api_version() in the constructor to fail, leaving zapi in ZabbixServer unset efter self._login().