-
-
Notifications
You must be signed in to change notification settings - Fork 2
Validate max player numbers #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "queryset_class": CustomQuerySet | ||
| } | ||
|
|
||
| def clean(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach is only clever, if we are sure there is no invalid data in the db already, which the system needs to be able to save again. Reading shouldn't be an issue, though.
|
I think we should remove the check whether one side has more than 50 players since theoretically 51vs49 is a valid linup. |
|
It is? 🤔 |
|
@Soxxes 51vs49 is a valid game right? |
|
The frontend, when used to report a match, currently checks for max 50 players per side as well 😅 |
|
Fair point but that doesn't make it right. |
|
Kudos, SonarCloud Quality Gate passed!
|








Fixes #78