Skip to content

Conversation

@wajdikhattel
Copy link
Contributor

The apply function already supports a list of mentions, so why not give the possibility to get a relation of multiple mentions.

This is needed in order for fonduer to support multary candidates.

@wajdikhattel wajdikhattel force-pushed the feat/multary_relation branch from 987e3a7 to c2477d2 Compare June 15, 2020 13:52
@senwu
Copy link
Contributor

senwu commented Jun 15, 2020

LGTM.

Two comments:

  1. Can you give few examples about the features generated by this PR?
  2. Did you test this PR?

@wajdikhattel
Copy link
Contributor Author

So I only tested this directly with fonduer, and I get around 50 new textual features when running the
test_multary_relation_feature_extraction at test_features.py

It's hard to get a screenshot of the example, but basically this will allow us to treat a relation between multiple mentions instead of just two.

What I can suggest is to run that test while un-commenting the textual features part in the test_features and in the featues/feature_libs/textual_features.py
And basically you'll notice that we have more features

image
image
image
The first n_textual_features is the one from the test_binary_relation_feature_extraction and the second is from the test_multary_relation_feature_extraction

@senwu
Copy link
Contributor

senwu commented Jun 16, 2020

Awesome! We can think about merging the apply_multary_relation and apply_relation later. This change might not backward compatible.

@senwu senwu merged commit 14dba06 into HazyResearch:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants