Skip to content

Conversation

HiromuHota
Copy link
Contributor

@HiromuHota HiromuHota commented Sep 8, 2020

Description of the problems or issues

Is your pull request related to a problem? Please describe.

See #471.

Does your pull request fix any issue.

Fix #471.

Description of the proposed changes

get_cell_ngrams yields nothing when the mention is not tabular to align with get_col_ngrams.

Test plan

Change the assertion at test_get_cell_ngrams.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.rst accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (cb24e08) to head (3b29633).
Report is 64 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          88       88           
  Lines        4571     4573    +2     
  Branches      855      855           
=======================================
+ Hits         3922     3924    +2     
  Misses        464      464           
  Partials      185      185           
Flag Coverage Δ
unittests 85.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/fonduer/utils/data_model_utils/tabular.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HiromuHota HiromuHota changed the title get_cell_ngrams yields nothing when the mention is not tabular (fix #471) get_cell_ngrams and get_neighbor_cell_ngrams yield nothing when the mention is not tabular (fix #471) Sep 8, 2020
@HiromuHota HiromuHota marked this pull request as ready for review September 9, 2020 18:24
@lukehsiao lukehsiao added this to the v0.8.3 milestone Sep 11, 2020
@lukehsiao lukehsiao added the clean-up Cleaning up the code or refactoring label Sep 11, 2020
Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems good to make them consistent behavior.

@lukehsiao lukehsiao merged commit 9113fb3 into HazyResearch:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-up Cleaning up the code or refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_col_ngrams and get_cell_ngrams return inconsistent result when a mention is not tabular

3 participants