Skip to content

Conversation

@haohaocreates
Copy link
Contributor

@haohaocreates haohaocreates commented May 22, 2024

This PR adds a Github Action (publish-node-action) that will run whenever the pyproject.toml file changes. The pyproject.toml defines the custom node version you want to publish (added in another PR).

Action Required:

  • Make sure the trigger branch (master or main) in publish.yaml matches the branch you want to use as the publishing branch. It will only trigger when the pyproject.toml gets updated on that branch.
  • Create an api key on the Registry for publishing from Github. Instructions.
  • Add it to your Github Repository Secrets as REGISTRY_ACCESS_TOKEN.

More info on the registry.
Please message me on Discord if you have any questions!

@HaydenReeve HaydenReeve self-assigned this Oct 21, 2024
@HaydenReeve HaydenReeve merged commit 73d82fe into HaydenReeve:main Nov 18, 2024
HaydenReeve pushed a commit that referenced this pull request Mar 27, 2025
Hey! My name is Robin and I'm from [comfy-org](https://comfy.org/)! We
would love to have you join the Comfy Registry, a public collection of
custom nodes which lets authors publish nodes by version and automate
testing against existing workflows. This PR updates the Github Action
`publish.yml` to ensure latest ComfyUI Community Standard.

## Updates:

1. **Issue Creating Permission**: Ensures that the workflow can open
issues to report publishing states or warnings, facilitating better
communication and issue tracking.

```diff
+ # auto issue permission, for Comfy CustomNode registry publishing state
+ permissions:
+   issues: write
```

2. **Conditional Execution**: Only runs the publish job in author’s
repo, defaults to repo owner, reference issue here: - [Forks problem:
add an organisation or owner check to run the action · Issue #2 ·
Comfy-Org/publish-node-action](Comfy-Org/publish-node-action#2)

```diff
+     if: ${{ github.repository_owner == 'HaydenReeve' }}
```

3. **Versioning**: We use explicit version number after stable release,
using a stable release version of the action reduces the risk of
unexpected behavior from changes in the action's main branch.

```diff
-     uses: Comfy-Org/publish-node-action@~~main~~
+     uses: Comfy-Org/publish-node-action@v1
```

## Learn More

Please message me on Discord at robin or join our
[server](https://discord.com/invite/comfyorg) server if you have any
questions! For more information, visit the official Comfy-Org blog:
[ComfyUI Blog](https://blog.comfy.org/).

Co-authored-by: snomiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants