Skip to content

h5cc is severely lacking when building hdf5 with cmake, breaking downstream users #1814

@BtbN

Description

@BtbN

When building hdf5 with autotools, the following file is used to produce h5cc and friends:
https://github.com/HDFGroup/hdf5/blob/develop/bin/h5cc.in

However, when building with cmake, the following file is used for it:
https://github.com/HDFGroup/hdf5/blob/develop/config/cmake/libh5cc.in

It is massively less complex, but also lacking a bunch of stuff.
So far, I have noticed the following two major issues:

A whole bunch of downstream users call "h5cc -show" in their configure scripts. That option is plain gone and gets passed to gcc if you use the cmake version, leading to various hilariously broken configure and build results (for example: slurm finishes configure, but produces a Makefile with syntax-errors).
I have so far only noticed -show being missing, but there's a bunch of other missing options that might cause issues if some downstream user relies on them.

Additionally:
The cmake version has "$dir/lib/libhdf5.settings" hardcoded in. So if things got installed into lib64, it breaks as well.

Metadata

Metadata

Assignees

Labels

Component - ToolsCommand-line tools like h5dump, includes high-level tools

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions